Skip to content

Earn – update user balance display#1024

Merged
jake4take merged 15 commits intodevelopfrom
feature/si-2546-earn-my-balance-token
Apr 28, 2026
Merged

Earn – update user balance display#1024
jake4take merged 15 commits intodevelopfrom
feature/si-2546-earn-my-balance-token

Conversation

@alx-khramov
Copy link
Copy Markdown
Contributor

Description

This pull request enhances how user vault balances are displayed across the Earn product, improving clarity and consistency for both ETH and DVV vaults. It introduces a more flexible balance prop, shows balances in both base and share tokens, and adds USD value display where available. Several style updates and code refactors support these improvements.

Vault Balance Display Improvements:

  • Refactored the balance display logic in VaultCard and TopSection components to support both "share" and "base" token amounts, as well as USD equivalents. This includes a new VaultBalanceProp type and conditional rendering for USD values and tooltips. [1] [2] [3] [4] [5]
  • Updated ETH and DVV vaults to provide both share and base token balances, and to pass these values through to the UI. ETH vaults now show ETH and share token balances, with USD value where available. [1] [2] [3] [4] [5] [6]

Styling and UI Enhancements:

  • Added new styled components for displaying sub-values (e.g., USD amounts) under the main balance, and improved responsive layout for vault statistics. [1] [2] [3]

Code Cleanup and Refactoring:

  • Removed unused or redundant code related to the old balance display, such as the VaultPosition component in ETH vault deposit requests. [1] [2] [3]
  • Updated hooks to provide both ETH and USD values for vault positions, and ensured all relevant components consume these values. [1] [2]

Prop and Type Updates:

  • Added and plumbed the new balance prop through VaultPage and related components to support the improved balance display. [1] [2] [3]

These changes collectively improve the user experience by making vault balances clearer and more informative, especially for users interacting with multiple token types and currencies.

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

Signed-off-by: Alexander Khramov <alx.khramov@gmail.com>
@alx-khramov alx-khramov self-assigned this Apr 16, 2026
@alx-khramov alx-khramov requested a review from a team as a code owner April 16, 2026 12:51
@preview-stands
Copy link
Copy Markdown

preview-stands Bot commented Apr 16, 2026

Preview stand status

Stand was demolished

Jeday
Jeday previously approved these changes Apr 17, 2026
Signed-off-by: Alexander Khramov <alx.khramov@gmail.com>
Signed-off-by: Alexander Khramov <alx.khramov@gmail.com>
Signed-off-by: Alexander Khramov <alx.khramov@gmail.com>
Signed-off-by: Alexander Khramov <alx.khramov@gmail.com>
… top section

Signed-off-by: Alexander Khramov <alx.khramov@gmail.com>
@alx-khramov alx-khramov requested a review from Jeday April 21, 2026 09:45
Signed-off-by: Alexander Khramov <alx.khramov@gmail.com>
Signed-off-by: Alexander Khramov <alx.khramov@gmail.com>
Signed-off-by: Alexander Khramov <alx.khramov@gmail.com>
Signed-off-by: Alexander Khramov <alx.khramov@gmail.com>
Signed-off-by: Alexander Khramov <alx.khramov@gmail.com>
@alx-khramov alx-khramov force-pushed the feature/si-2546-earn-my-balance-token branch from eaf0668 to ff9f106 Compare April 27, 2026 17:52
Signed-off-by: Alexander Khramov <alx.khramov@gmail.com>
Signed-off-by: Alexander Khramov <alx.khramov@gmail.com>
Signed-off-by: Alexander Khramov <alx.khramov@gmail.com>
@jake4take jake4take merged commit 3da2610 into develop Apr 28, 2026
7 of 8 checks passed
@jake4take jake4take deleted the feature/si-2546-earn-my-balance-token branch April 28, 2026 12:14
@jake4take jake4take mentioned this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants